Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

</p> attempted to close an element that was not open #1371

Closed
NazCodeland opened this issue Apr 26, 2023 · 1 comment
Closed

</p> attempted to close an element that was not open #1371

NazCodeland opened this issue Apr 26, 2023 · 1 comment

Comments

@NazCodeland
Copy link

NazCodeland commented Apr 26, 2023

Hello, I am using the svelte Giscus component in my project. I am also using the MDsveX package in my project and I thought originally my issue was related to that package so I opened a ticket there: pngwn/MDsveX#505.

I've come to learn the issue is due to the HTML custom element <gitcus-widget>, not closing itself with an explicit closing tag. It's using the 'shorthand' form, <giscus-widget ... /> to close itself instead of the longhand form, <giscus-widget ... ></giscus-widget>

// Giscus.svelte
<script>
 ...
 ...
</script>

{#if mounted}
 <giscus-widget
   {id}
   {host}
   {repo}
   repoid={repoId}
   {category}
   categoryid={categoryId}
   {mapping}
   {term}
   {strict}
   reactionsenabled={reactionsEnabled}
   emitmetadata={emitMetadata}
   inputposition={inputPosition}
   {theme}
   {lang}
   {loading}
 />
{/if}

I would like to do a pull request and fix this minor issue. I've read CONTRIBUTING.md and I am wondering, since, I am only changing the custom HTML elements to explicitly close, if I also need to follow the instructions in SELF-HOSTING.md, or can I contribute without doing the self-hosting? Thanks in advance.

@laymonage
Copy link
Member

Should be fixed in v2.3.0, please update and confirm. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants