You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I am using the svelte Giscus component in my project. I am also using the MDsveX package in my project and I thought originally my issue was related to that package so I opened a ticket there: pngwn/MDsveX#505.
I've come to learn the issue is due to the HTML custom element <gitcus-widget>, not closing itself with an explicit closing tag. It's using the 'shorthand' form, <giscus-widget ... /> to close itself instead of the longhand form, <giscus-widget ... ></giscus-widget>
I would like to do a pull request and fix this minor issue. I've read CONTRIBUTING.md and I am wondering, since, I am only changing the custom HTML elements to explicitly close, if I also need to follow the instructions in SELF-HOSTING.md, or can I contribute without doing the self-hosting? Thanks in advance.
The text was updated successfully, but these errors were encountered:
Hello, I am using the svelte Giscus component in my project. I am also using the MDsveX package in my project and I thought originally my issue was related to that package so I opened a ticket there: pngwn/MDsveX#505.
I've come to learn the issue is due to the HTML custom element
<gitcus-widget>
, not closing itself with an explicit closing tag. It's using the 'shorthand' form,<giscus-widget ... />
to close itself instead of thelonghand
form,<giscus-widget ... ></giscus-widget>
I would like to do a pull request and fix this minor issue. I've read
CONTRIBUTING.md
and I am wondering, since, I am only changing the custom HTML elements to explicitly close, if I also need to follow the instructions inSELF-HOSTING.md
, or can I contribute without doing the self-hosting? Thanks in advance.The text was updated successfully, but these errors were encountered: