Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check_patches before applying #74

Open
jaumef opened this issue Oct 3, 2018 · 0 comments
Open

Improve check_patches before applying #74

jaumef opened this issue Oct 3, 2018 · 0 comments

Comments

@jaumef
Copy link
Contributor

jaumef commented Oct 3, 2018

When applying with "--from-commit" option, instead of using the ".patch" files uploaded, it uses all the patches on the "patch/<pr_number>" path.

This generates 2 problems:

  • Slow check for all files (sorted by commit number) to find which one has the correct hash
  • May apply more commits than uploaded
    • Patches made manually that are sorted under the ones uploaded
    • Copies of the patch files
    • A commit that was uploaded and then removed with a "push --force"
    • ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant