Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy failing locally but passing in clippy-action #84

Open
wmmc88 opened this issue Nov 10, 2023 · 0 comments
Open

clippy failing locally but passing in clippy-action #84

wmmc88 opened this issue Nov 10, 2023 · 0 comments

Comments

@wmmc88
Copy link

wmmc88 commented Nov 10, 2023

Local output:

πŸͺŸ Windows 11 Enterprise(10.0.23580) (pwsh) fix-arm64 on ξ‚  fix-clippy-pipeline [$] via πŸ¦€ v1.73.0 
at 04:29:46 PM ❯ cargo --version   
cargo 1.73.0 (9c4383fb5 2023-08-26)

πŸͺŸ Windows 11 Enterprise(10.0.23580) (pwsh) fix-arm64 on ξ‚  fix-clippy-pipeline [$] via πŸ¦€ v1.73.0 
at 04:29:51 PM ❯ git rev-parse HEAD
f4a1cc0cc0cbe87364b30e3a5ec076db93247bef

πŸͺŸ Windows 11 Enterprise(10.0.23580) (pwsh) fix-arm64 on ξ‚  fix-clippy-pipeline [$] via πŸ¦€ v1.73.0 
at 04:29:53 PM ❯ cargo clippy
   Compiling wdk-build v0.1.0 (D:\git-repos\github\windows-drivers-rs.git\fix-arm64\crates\wdk-build)
error: you should put bare URLs between `<`/`>` or make a proper Markdown link
  --> crates\wdk-build\src\cargo_make.rs:20:53
   |
20 | /// `clap` uses an exit code of 2 for usage errors: https://github.com/clap-rs/clap/blob/14fd853fb9c5b94e371170bbd0ca2bf28ef3abff/clap_builder/src/util/mod.rs#L30C18-L30C28
   |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
  --> crates\wdk-build\src\lib.rs:16:9
   |
16 | #![deny(clippy::pedantic)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[deny(clippy::doc_markdown)]` implied by `#[deny(clippy::pedantic)]`

error: docs for function which may panic missing `# Panics` section
   --> crates\wdk-build\src\cargo_make.rs:324:1
    |
324 | pub fn validate_and_forward_args() {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: first possible panic found here
   --> crates\wdk-build\src\cargo_make.rs:335:13
    |
335 | /             env_args
336 | |                 .remove(TOOLCHAIN_ARG_POSITION)
337 | |                 .to_string_lossy()
338 | |                 .strip_prefix('+')
339 | |                 .expect("Toolchain arg should have a + prefix")
    | |_______________________________________________________________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
    = note: `#[deny(clippy::missing_panics_doc)]` implied by `#[deny(clippy::pedantic)]`

error: could not compile `wdk-build` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `wdk-build` (lib) due to 2 previous errors

clippy action(from https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:2)771/Microsoft.DesktopAppInstaller_8wekyb[3](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836 in wmmc88/windows-drivers-rs#13):

Run giraffate/clippy-action@v1
  with:
    tool_name: Clippy
    clippy_flags: --locked --profile dev --all-targets -- -D warnings
    reporter: github-check
    github_token: ***
    filter_mode: nofilter
    fail_on_error: true
    level: info
    workdir: .
    reviewdog_version: latest
  env:
    LatestWingetDownloadUri: https://github.com/microsoft/winget-cli/releases/download/v1.6.[2](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:2)771/Microsoft.DesktopAppInstaller_8wekyb[3](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:3)d8bbwe.msixbundle
    LatestWingetLicenseDownloadUri: https://github.com/microsoft/winget-cli/releases/download/v1.6.2771/27abf0d1afe3[4](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:4)0e7a64fb6960[5](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:5)[6](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:6)b26[7](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:7)2_License1.xml
    CARGO_INCREMENTAL: 0
    CARGO_TERM_COLOR: always
🐢 Installing reviewdog ... https://github.com/reviewdog/reviewdog
  finding a release for latest
  downloading from https://github.com/reviewdog/reviewdog/releases/download/v0.15.0/reviewdog_0.15.0_Windows_x[8](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:8)6_64.tar.gz
  extracting
  C:\Windows\system32\tar.exe xz -C D:\a\_temp\reviewdog-RAKtEN -f D:\a\_temp\[9](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:9)a6feb82-21c1-4154-bee7-0730f9e37f86
Running Clippy with reviewdog 🐢 ...
  D:\a\_temp\reviewdog-RAKtEN\reviewdog.exe -efm=<pre><code>%E%f:%l:%c:%t:%m -efm=%E%f:%l:%c:%t:%m -efm=%Z__END__ -efm=%C%m</code></pre> -efm=%C%m -efm=%C -name=Clippy -reporter=github-check -filter-mode=nofilter -fail-on-error=true -level=info
  2023/11/[10](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:10) 00:20:00 [Clippy] reported: https://github.com/wmmc88/windows-drivers-rs/runs/[18](https://github.com/wmmc88/windows-drivers-rs/actions/runs/6818832114/job/18545139836#step:6:19)545690569 (conclusion=success)

possibly related to #46 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant