Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(binding): dereference pointer to struct when validating structs #3199

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix(binding): dereference pointer to struct when validating structs #3199

merged 1 commit into from
Feb 7, 2024

Conversation

echovl
Copy link
Contributor

@echovl echovl commented Jun 14, 2022

Fixes #3143

@shushenghong
Copy link

yes, that's really a bug, just pass pointer to go-validator, no need depoint, this will cause the whole struct unaddressable. please merge

@appleboy appleboy added the bug label Dec 17, 2023
@appleboy appleboy added this to the v1.10 milestone Dec 17, 2023
@appleboy appleboy changed the title fix: dereference pointer to struct when validating structs fix(binding): dereference pointer to struct when validating structs Feb 7, 2024
@appleboy appleboy merged commit 82bcd6d into gin-gonic:master Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@thinkerou thinkerou Awaiting requested review from thinkerou

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

unable to pass a pointer to struct level validator (works with a workaround)
3 participants
@echovl @shushenghong @appleboy