Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gin's Context implementation of context.Context #2516

Closed
Julio-Guerra opened this issue Sep 30, 2020 · 2 comments
Closed

Gin's Context implementation of context.Context #2516

Julio-Guerra opened this issue Sep 30, 2020 · 2 comments

Comments

@Julio-Guerra
Copy link

Hello,

Based on those lines implementing the context.Context interface, Gin should either proxy those calls to c.Request.Context() or otherwise not implement context.Context at all. This leads to mistakes and errors since one can think Gin's context will behave as a request context...

Same with the value storage which should also go into the request context in my opinion if you really want to implement context.Context.

@kszafran
Copy link
Contributor

kszafran commented Aug 6, 2021

This has been solved by #2769, but weirdly it's not present in v1.7.3.

@appleboy
Copy link
Member

appleboy commented Jun 2, 2022

release in v1.8.0

@appleboy appleboy closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants