-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pe rich header #375
Merged
Merged
Pe rich header #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daladim
commented
Sep 10, 2021
daladim
force-pushed
the
pe_rich_header
branch
from
September 10, 2021 15:18
6e03413
to
e206d57
Compare
daladim
force-pushed
the
pe_rich_header
branch
from
September 10, 2021 15:20
e206d57
to
776b70f
Compare
philipc
requested changes
Sep 10, 2021
daladim
force-pushed
the
pe_rich_header
branch
from
September 16, 2021 13:31
7590b1a
to
374ba94
Compare
philipc
requested changes
Sep 17, 2021
daladim
force-pushed
the
pe_rich_header
branch
from
September 17, 2021 12:36
cc3c367
to
c6b645c
Compare
philipc
reviewed
Sep 17, 2021
daladim
force-pushed
the
pe_rich_header
branch
from
September 20, 2021 08:38
97f06a9
to
e977b56
Compare
philipc
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
FYI I'll do a follow up PR with readobj support and some small style changes.
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at resolving #339 .
There is still a part that needs implementation, and I myself have a few questions for you in the comments of this pull request