Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on an outdated and soon-to-be-defunct version of wasmparser #523

Closed
kornelski opened this issue Mar 14, 2023 · 5 comments · Fixed by #528
Closed

Depends on an outdated and soon-to-be-defunct version of wasmparser #523

kornelski opened this issue Mar 14, 2023 · 5 comments · Fixed by #528

Comments

@kornelski
Copy link

Compilation of gimli examples warns:

warning: the following packages contain code that will be rejected by a future version of Rust: wasmparser v0.57.0

warning: trailing semicolon in macro used in expression position
rust-lang/rust#79813

This error is in a very very old version of wasmparser, so presumably it has been fixed already, but object still has a dev-dependency on the bad old version.

@philipc
Copy link
Contributor

philipc commented Mar 15, 2023

wasm support in this crate hasn't been maintained for a long time. @RReverser Are you still using the wasm support?

@RReverser
Copy link
Contributor

Not in the current project, but I do from time to time. In theory, Wasm support shouldn't require active maintenance, since it's just used as a container for DWARF sections, but bumping the dependency is worthwhile, yeah.

@philipc
Copy link
Contributor

philipc commented Mar 30, 2023

@RReverser Updating wasmparser is a large task which I personally do not wish to undertake. What exactly do you need from the wasm support in this crate? Can we go back to a simple parser which is sufficient to provide access to the DWARF sections (which is all I need it for)?

@philipc
Copy link
Contributor

philipc commented Mar 30, 2023

It ended up not being too bad to update wasmparser, see #528.

@RReverser
Copy link
Contributor

Can we go back to a simple parser which is sufficient to provide access to the DWARF sections (which is all I need it for)?

Hm I don't really remember enough context, it's been years - what do you mean by "go back" or "simple parser"?

It ended up not being too bad to update wasmparser, see #528.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants