Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing with nightly rust due to packed debuginfo #256

Closed
philipc opened this issue Sep 13, 2022 · 4 comments · Fixed by #258
Closed

Tests are failing with nightly rust due to packed debuginfo #256

philipc opened this issue Sep 13, 2022 · 4 comments · Fixed by #258

Comments

@philipc
Copy link
Contributor

philipc commented Sep 13, 2022

Currently the tests require Linux builds to use split-debuginfo=off and macOS builds to use split-debuginfo=packed. On stable rust, we achieve this with split-debuginfo=packed in Cargo.toml. This works because this option is only supported for macOS. However, nightly rust has stabilized this option for Linux as well, and so now CI is failing.

I can't see how to specify platform specific options in profiles. For example, I would expect something like this to work, but it doesn't:

[target.'cfg(macos)'.profile.test]
split-debuginfo = 'packed'

@davidtwco Do you know how to achieve this? Is it intended that all platforms must use the same split-debuginfo settings?

@bjorn3
Copy link
Contributor

bjorn3 commented Sep 13, 2022

macOS defaults to packed for back compat reasons, so not setting split-debuginfo at all should work.

@philipc
Copy link
Contributor Author

philipc commented Sep 13, 2022

Hmm, can't test that now, but the reason I had this in the first place is because it was defaulting to unpacked.

@bjorn3
Copy link
Contributor

bjorn3 commented Sep 13, 2022

Right, cargo changed the default in rust-lang/cargo#9298. My bad.

@philipc
Copy link
Contributor Author

philipc commented Nov 3, 2022

The relevant cargo issue is rust-lang/cargo#4897

We can use environment variables to work around this in CI, but the cargo setting would still be preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants