Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'US' country matcher does not work #28

Closed
chummer80 opened this issue Apr 30, 2020 · 3 comments
Closed

'US' country matcher does not work #28

chummer80 opened this issue Apr 30, 2020 · 3 comments

Comments

@chummer80
Copy link

chummer80 commented Apr 30, 2020

Using:
webpack 4.38.0
moment-timezone 0.5.28
moment-timezone-data-webpack-plugin 1.2.0

Issue:

matchCountries: 'US'

does not seem to filter out any data, but

matchCountries: 'us'

does correctly filter out data for timezones outside the US.

For now I'll use ['US', 'us'] in my config

@chummer80
Copy link
Author

chummer80 commented Apr 30, 2020

Additional info:

Contrary to my previous plan of using ['US', 'us'], I will actually go back to using only 'us'. This is because including 'US' causes the same type error that was described in issue #27.

@gilmoreorless
Copy link
Owner

I've released version 1.3.0 which contains a fix for the 'US' country code (and a few others).

I'm intrigued that you got matchCountries: 'us' to work though. When I tried it there were 0 zones added to the data (it filtered out everything).

@chummer80
Copy link
Author

You're right, 'us' only appeared to be working because there was no type error. Sorry for the misinformation and thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants