Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not return countries data #22

Closed
palashkaria opened this issue Mar 28, 2020 · 3 comments · Fixed by #24
Closed

Does not return countries data #22

palashkaria opened this issue Mar 28, 2020 · 3 comments · Fixed by #24

Comments

@palashkaria
Copy link

countries is an empty array, and there's no way to pass the same currently
(see cache screenshot)

The problem is in this L30 in index.js, where we pass only zones and version while creating the data.
https://github.com/gilmoreorless/moment-timezone-data-webpack-plugin/blob/master/src/index.js#L30

Should there be an option to pass country data too?

image

@gilmoreorless
Copy link
Owner

Thanks for raising this! The adding of country data to the API only happened in the most recent release of moment-timezone (0.5.28, although there's some confusion about the exact version) — so it's not yet accounted for by this plugin.

I'll take a look into adding filtered country data as well.

@gilmoreorless
Copy link
Owner

The fix for this is now available in version 1.2.0.

@palashkaria
Copy link
Author

palashkaria commented Apr 14, 2020

Thanks a lot, this works perfectly for my use case! I had created a (bad) local copy of the plugin which I can delete now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants