Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motorway casing of bridge rendered above adjacent fill #46

Open
nrenner opened this issue Nov 23, 2019 · 3 comments
Open

Motorway casing of bridge rendered above adjacent fill #46

nrenner opened this issue Nov 23, 2019 · 3 comments

Comments

@nrenner
Copy link

nrenner commented Nov 23, 2019

Expected behavior

The normal casing for motorway bridges (not the black bridge casing) should be rendered below regular motorway fill.

Actual behavior

It seems that casing for motorway bridges is rendered above regular motorway fill, it crosses the fill of adjacent motorway lines at the ends of the bridge line and thus the inner motorway line is interrupted by casing at the start and end of a bridge.

Links and screenshots illustrating the problem

image

https://www.openstreetmap.de/karte.html?zoom=18&lat=48.25238&lon=12.20842&layers=B000TF
https://www.openstreetmap.org/way/333888896

@giggls
Copy link
Owner

giggls commented Nov 24, 2019

Motorway and trunk overlays (the yellow and white lines) are drawn at line 2540 of roads.mss.
Try moving this code block and see if this works. Use ./scripts/render_single_tile.py for a test.
I know about this issue. If you have an easy fix just send a pull request.

@giggls
Copy link
Owner

giggls commented Nov 24, 2019

I had a look at this more closely. Unfortunately this is not a matter of layering.
Motorway fill is rendered as a line with rounded ends to avoid gaps line-cap: round;

Unfortunately this means, that the overlays in German style will not be long enough.

I have no idea if there is a way to extend a line before rendering it which is what would be needed in this case.

@nrenner
Copy link
Author

nrenner commented Nov 26, 2019

Thanks that you had a look.

I just assumed a layering issue based on how it looks, but I don't have a fix. I would find it interesting to dig into this, but already have too many other loose ends right now.

And thanks for maintaining the style and the servers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants