Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle backend timeout gracefully #25

Open
giftig opened this issue Nov 29, 2016 · 1 comment
Open

Handle backend timeout gracefully #25

giftig opened this issue Nov 29, 2016 · 1 comment

Comments

@giftig
Copy link
Owner

giftig commented Nov 29, 2016

Not currently logging anything when it takes a long time to talk to redis; the request times out and spray tells the client it wasn't able to respond in a timely manner, but nothing is logged to help narrow down the problem. It'll be useful to log before and after hitting the db so that timings are visible, and to handle timeouts by logging the issue and possibly serving a JSON response to match the rest of the API rather than falling back on spray's text/plain one (maybe. Status code is probably good enough; passing back JSON won't add much information).

@giftig
Copy link
Owner Author

giftig commented Nov 29, 2016

I should also document the dangers of sharing a redis db with flippy since it SCANs the keyset.

@giftig giftig changed the title Handle redis timeout gracefully Handle backend timeout gracefully Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant