This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Fix group name in generated YAML filenames of Cluster and MachineDeployment #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marians
changed the title
|
Still need to fix something here... |
tfussell
reviewed
Apr 9, 2020
| crd := NewMachineDeploymentCRD() | ||
|
|
||
| crdGroup := crd.Spec.Group | ||
| crdKindLower := strings.ToLower(crd.Spec.Names.Kind) |
There was a problem hiding this comment.
I've been playing around with kubebuilder recently and discovered that the suffix should actually be crd.Spec.Names.Plural (so cluster.x-k8s.io_machinedeployments.yaml) I plan to make this change in my upcoming PR so it's not super important here--just wanted to mention.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/8804