Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK: 1024x1024 icon not installed #3967

Closed
mitchellh opened this issue Dec 29, 2024 · 0 comments · Fixed by #4003
Closed

GTK: 1024x1024 icon not installed #3967

mitchellh opened this issue Dec 29, 2024 · 0 comments · Fixed by #4003

Comments

@mitchellh
Copy link
Contributor

Discussed in #3856

Originally posted by rivenirvana December 28, 2024
I'm wondering if leaving it out was intentional, but I doubt it since the size is supported. But in the new icon commit (247409d), a 1024x1024 size icon was introduced for use in Linux but was left unused by build.zig. I'm maintaining a COPR package for this and that's when I noticed, but instead of manually installing it in the package spec, I figured it'd be better to let the upstream build file handle this as well if it was unintentionally left out.

If so, I'd like to make a PR with these changes (main...rivenirvana:ghostty:install-icon-1024). Let me know if there's anything I missed, but I can confirm that this builds properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant