Memory leak when resizing quickly

[kdrag0n]

Repro:

• Try to match the window size shown here, so that the terminal isn't much wider than the xxd output lines
• Run xxd /dev/zero for a bit to fill the scrollback buffer
• Stop it with Ctrl-C
• Repeatedly grow and shrink the window horizontally. Don't wait for reflow to finish; keep resizing it back and forth while it's still busy reflowing for the last resize event.

Unlike #1853, this memory is released when the respective split/tab/surface is closed, but it's not released as long as the surface exists.

All the leaked memory is in raw mmap regions in this case (as shown by footprint), so I think it's caused by leaked Pages.

Scrollback buffer should be large enough that reflow takes a noticeable amount of time.

Screenshot.2024-06-09.at.09.32.31.PM.mp4

[kdrag0n]

Slowly but steadily growing OR shrinking in one direction (without waiting for reflow) seems to be the most reliable way to reproduce this.

[kdrag0n]

It also helps to have a high scrollback limit to make this more obvious. Mine's set to 1 GB.

[mitchellh]

I tried the easy thing by replacing posix.mmap with std.testing.allocator and hoping the unit tests saw anything weird (since the testing allocator does leak detection). No leaks detected, so it wasn't going to be that easy. 😄 Still looking.

[qwerasd205]

I cannot reproduce this. @kdrag0n, can you test again on the latest version and see if you still get this behavior? It's possible one of the recent changes fixed whatever was causing this.

[kdrag0n]

Hmm, I'm still seeing this on 7741463.

[kdrag0n]

Can you try this config and font (just in case it somehow matters)?

font-family = "Twilio Sans Mono"
font-family = "Cascadia Code"
font-style-bold = Semibold
font-style-bold-italic = "Semibold Italic"
font-size = 14

#adjust-cell-height = 5%

# 100 chars * 10 million
scrollback-limit = 1000000000
adjust-cursor-thickness = 200%
cursor-style-blink = false

mouse-hide-while-typing = false
mouse-scroll-multiplier = 1.5

keybind = super+f=write_scrollback_file

window-padding-x = 6
window-padding-y = 6

window-save-state = always

copy-on-select = clipboard

#macos-titlebar-tabs = true
unfocused-split-opacity = 0.8

term = xterm-256color

minimum-contrast = 1.1
#bold-is-bright = true

config-file = theme
window-theme = system

#shell-integration = none

focus-follows-mouse = true

[qwerasd205]

I can reproduce this with your config! I'll try to narrow down the exact cause. (My suspicion is that it could be related to copy-on-select or focus-follows-mouse)

[qwerasd205]

Nevermind... now I can reproduce it without the config... either way I am working on debugging the problem now.