Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skipValidation to makeRestService and makeWebSocketService #256

Closed
ghostdogpr opened this issue Mar 1, 2020 · 2 comments · Fixed by #260
Closed

Add skipValidation to makeRestService and makeWebSocketService #256

ghostdogpr opened this issue Mar 1, 2020 · 2 comments · Fixed by #260
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ghostdogpr
Copy link
Owner

ghostdogpr commented Mar 1, 2020 •
edited
Loading

The execute method on an interpreter has a parameter skipValidation, but it's not possible to use it when using one of the Http adapters.

Add a new parameter skipValidation: Boolean = false to makeRestService and makeWebSocketService in each adapter that will be passed to execute, so that this feature can be used more easily.

  • Http4sAdapter
  • AkkaHttpAdapter
  • FinchAdapter
@ghostdogpr ghostdogpr added enhancement New feature or request good first issue Good for newcomers labels Mar 1, 2020
@javimartinez
Copy link
Contributor

Hi! I would like to contribute to the project, can I take this one?

@ghostdogpr
Copy link
Owner Author

@javimartinez sure! Let me know if you need any help 👍

@javimartinez javimartinez mentioned this issue Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add skipValidation to Http4sAdapter, AkkaHttpAdapter and FinchAdapter javimartinez/caliban
2 participants
@ghostdogpr @javimartinez