Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input objects are not properly encoded #249

Closed
ghostdogpr opened this issue Feb 29, 2020 · 1 comment · Fixed by #253
Closed

Input objects are not properly encoded #249

ghostdogpr opened this issue Feb 29, 2020 · 1 comment · Fixed by #253
Labels
bug Something isn't working client GraphQL Client module

Comments

@ghostdogpr
Copy link
Owner

Input object fields are surrounded with double quotes, but they should not.

"field": value should be field: value

The problem is that we use Value#toString to encode input values, but that gives a JSON-like representation which is not the one we want here.
@ghostdogpr ghostdogpr added bug Something isn't working client GraphQL Client module labels Feb 29, 2020
@ghostdogpr
Copy link
Owner Author

Working on it

@ghostdogpr ghostdogpr mentioned this issue Feb 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working client GraphQL Client module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix input values encoding ghostdogpr/caliban
1 participant
@ghostdogpr