Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support creating graphiql endpoints for tapir based adapters #2376

Closed
calvinlfer opened this issue Aug 25, 2024 · 2 comments · Fixed by #2379
Closed

Support creating graphiql endpoints for tapir based adapters #2376

calvinlfer opened this issue Aug 25, 2024 · 2 comments · Fixed by #2379
Labels
adapters Issue related to HTTP adapters enhancement New feature or request good first issue Good for newcomers server Issue related to caliban server

Comments

@calvinlfer
Copy link
Contributor

Currently only the quick adapter provides the graphiql endpoint but the other (tapir based) adapters are left to the user to implement.

It would be nice to provide graphiql endpoints to more adapters
@calvinlfer calvinlfer mentioned this issue Aug 25, 2024
Merged
@ghostdogpr ghostdogpr added enhancement New feature or request good first issue Good for newcomers server Issue related to caliban server adapters Issue related to HTTP adapters labels Aug 26, 2024
@calvinlfer
Copy link
Contributor Author

Should we create a graphiql module which exposes the html method that quick currently uses and then have all the dependencies depend on this module and expose the appropriate datatypes?

@ghostdogpr
Copy link
Owner

If it doesn't require any extra dependency I think it's okay to put it in core.

@kyri-petrou kyri-petrou mentioned this issue Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapters Issue related to HTTP adapters enhancement New feature or request good first issue Good for newcomers server Issue related to caliban server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Graphiql endpoints for tapir adapters ghostdogpr/caliban
2 participants
@ghostdogpr @calvinlfer