Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pekko variant? #1823

Closed
MichelEdkrantz opened this issue Jul 31, 2023 · 2 comments
Closed

Pekko variant? #1823

MichelEdkrantz opened this issue Jul 31, 2023 · 2 comments
Labels
adapters Issue related to HTTP adapters

Comments

@MichelEdkrantz
Copy link
Contributor

Hi!
Thanks for this great lib :) Now that Pekko 1.0 has been released, is there any interest from your end to provide a pekko variant of this?

https://github.com/apache/incubator-pekko

I believe it would be most a copy of this, but with imports changed to pekko.
https://github.com/ghostdogpr/caliban/blob/series/2.x/adapters/akka-http/src/main/scala/caliban/AkkaHttpAdapter.scala

Tapir has no pekko support yet, but looks like it's in the making
softwaremill/tapir#2884
@ghostdogpr
Copy link
Owner

Yeah, I'm definitely okay with having a pekko-http adapter.

As you said, we need tapir support first but as soon as it's available we can add that adapter (it'll be quite easy).

@ghostdogpr ghostdogpr added the adapters Issue related to HTTP adapters label Jul 31, 2023
@MichelEdkrantz
Copy link
Contributor Author

Created a fork and a PR in #1862. Some issues remain but hoping to move this forward somehow 😅

@MichelEdkrantz MichelEdkrantz mentioned this issue Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapters Issue related to HTTP adapters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichelEdkrantz @ghostdogpr