Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert StreamStep to a ListStep for queries and mutations #155

Closed
ghostdogpr opened this issue Jan 6, 2020 · 0 comments · Fixed by #174
Closed

Convert StreamStep to a ListStep for queries and mutations #155

ghostdogpr opened this issue Jan 6, 2020 · 0 comments · Fixed by #174
Labels
enhancement New feature or request server Issue related to caliban server

Comments

@ghostdogpr
Copy link
Owner

StreamStep return a StreamValue after execution, but this only makes sense when using subscriptions. For queries and mutations, we could run the stream and return a ListValue of the result instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request server Issue related to caliban server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert StreamStep to a ListStep for queries and mutations ghostdogpr/caliban
1 participant
@ghostdogpr