-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate integration of Saucelabs in order to test cross-browser compatibility on commit #12
Comments
Indeed @evilaliv3; that would be great, sadly I have no time right now for these but would gladly merge a PR that does this. Thanks for the suggestion! |
okay! i'm about to make my pull with the following changes:
\cc jamesclark92 |
@evilaliv3 What libraries does grunt have that gulp doesn't? I personally prefer gulp as I find it easier to setup |
You are right @jamesclark92 i've quite finished implementing it all in gulp ;) |
Fixed on 94ec9a6 |
great! @ghostbar i noticed that i put a wrong url in the readme; https://travis-ci.org/ghostbar/angular-zxcvbn.js should be replaced with https://travis-ci.org/ghostbar/angular-zxcvbn |
I was just seeing that :) Fixing it right now ;-) |
great! i do not know why the build is failing for you. have you changed something while merging? https://travis-ci.org/ghostbar/angular-zxcvbn/jobs/116268281 |
Yes, and just fixed it too on 8b7e69a |
ehehe k the last few errors i did:
replace 'evilaliv3' with 'angular' in both this links. in addition add a newline on the Readme.md where i added myself as contributor (if you like to keep me ;)) |
Done and done ;-) |
It would be valuable to integrate with Saucelabs in order totest cross-browser compatibility tests on commit.
As the library is using karma as testing framework my suggestion is to start implemeting them using karma-sauce-launcher.
This way it will be possiblle to automatically execute all the unit test on the selection of browsers targetted by the library (all) and know proactively where it is not working.
E.g.: https://github.com/globaleaks/GlobaLeaks
It would be also nice to start tracking the code quality of the project using for example CodeClimate and tracking also the code coverage by means of Coveralls + karma-coveralls
The text was updated successfully, but these errors were encountered: