Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate integration of Saucelabs in order to test cross-browser compatibility on commit #12

Closed
evilaliv3 opened this issue Mar 14, 2016 · 11 comments

Comments

@evilaliv3
Copy link
Contributor

It would be valuable to integrate with Saucelabs in order totest cross-browser compatibility tests on commit.

As the library is using karma as testing framework my suggestion is to start implemeting them using karma-sauce-launcher.

This way it will be possiblle to automatically execute all the unit test on the selection of browsers targetted by the library (all) and know proactively where it is not working.

E.g.: https://github.com/globaleaks/GlobaLeaks
screenshot from 2016-03-14 20 36 40

It would be also nice to start tracking the code quality of the project using for example CodeClimate and tracking also the code coverage by means of Coveralls + karma-coveralls

@ghostbar
Copy link
Owner

Indeed @evilaliv3; that would be great, sadly I have no time right now for these but would gladly merge a PR that does this.

Thanks for the suggestion!

@evilaliv3
Copy link
Contributor Author

okay!

i'm about to make my pull with the following changes:

  • saucelabs+codeclimate integration + coverage tracking
  • update of all dependencies to latest versions
  • replacement of gulp with grunt as it benefits of more packages in relation to this topic.

\cc jamesclark92

@jamesclark92
Copy link
Collaborator

@evilaliv3 What libraries does grunt have that gulp doesn't? I personally prefer gulp as I find it easier to setup

@evilaliv3
Copy link
Contributor Author

You are right @jamesclark92

i've quite finished implementing it all in gulp ;)

@ghostbar
Copy link
Owner

Fixed on 94ec9a6

@evilaliv3
Copy link
Contributor Author

great!

@ghostbar i noticed that i put a wrong url in the readme;

https://travis-ci.org/ghostbar/angular-zxcvbn.js should be replaced with https://travis-ci.org/ghostbar/angular-zxcvbn

@ghostbar
Copy link
Owner

I was just seeing that :) Fixing it right now ;-)

@evilaliv3
Copy link
Contributor Author

great!

i do not know why the build is failing for you. have you changed something while merging?

https://travis-ci.org/ghostbar/angular-zxcvbn/jobs/116268281

@ghostbar
Copy link
Owner

Yes, and just fixed it too on 8b7e69a

@evilaliv3
Copy link
Contributor Author

ehehe k

the last few errors i did:

[![Saucelabs Test Status](https://saucelabs.com/browser-matrix/evilaliv3-zxcvbn.svg)](https://saucelabs.com/u/evilaliv3-zxcvbn)

replace 'evilaliv3' with 'angular' in both this links.

in addition add a newline on the Readme.md where i added myself as contributor (if you like to keep me ;))

@ghostbar
Copy link
Owner

Done and done ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants