Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter via macro not working as first filter #97

Closed
ghost91- opened this issue Dec 11, 2021 · 4 comments
Closed

Filter via macro not working as first filter #97

ghost91- opened this issue Dec 11, 2021 · 4 comments
Labels
bug Something isn't working confirmed

Comments

@ghost91-
Copy link
Contributor

ghost91- commented Dec 11, 2021

In GitLab by @Danii0206 on Dec 6, 2021, 19:00
https://gitlab.com/mesfoliesludiques/foundryvtt-fxmaster/-/issues/171

Hi,

first: thank you for this awesome module!

Now to the bugreport: I made a macro to switch the colorfilter. (Btw the example in the compendium seems outdated.)
It does work, but only if I use a filter through the left hand menu first. The macro only works as the second filter applied. Doesn't matter if the first is still active, only that there was another filter before I use the macro.

The code I use is:

FXMASTER.filters.switch("redfilterID", "color", { color: {value: "#880000", apply: true}, gamma: 1.0, contrast: 1.0, brightness: 1.0, saturation: 1.0 });

Am I missing something or is this indeed a bug?

Kind regards
Danii

@ghost91- ghost91- added bug Something isn't working can't reproduce labels Dec 11, 2021
@ghost91-
Copy link
Contributor Author

@Danii0206 With which version of foundry and did you run into this? Can you still reproduce it?

@Danii0206
Copy link

Danii0206 commented Dec 13, 2021

Yes I can reproduce it on every scene I create.

Steps to reproduce:

  • make new scene with background picture
  • activate the new scene
  • execute macro (see above post)

Expected outcome:
Scene turns red

Observed outcome:

  • No change to scene
  • In FXMaster Filter Controls the color filter is set to the options defined by the macro

Workaround:

  • make new scene
  • activate the new scene
  • set any colorfilter through fxmaster filter controls
  • delete colorfilter
  • use macro
  • scene turns red

Foundry 0.8.9
FXMaster 1.2.1
System: Vampire the Masquerade 5e 1.7.1

@ghost91-
Copy link
Contributor Author

Thanks for the info, I was also able to reproduce it now. I will look into it.

@ghost91-
Copy link
Contributor Author

I figured out what the problem was. I'll create a release with the fix as soon as possible but first maintenance of FXMaster needs to be transferred to me by foundry support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

No branches or pull requests

2 participants