feat(editors): add target to onBeforeEditCell w/called by composite
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we need a way to identify when the `onBeforeEditCell` is called by the Composite Editor modal or by the inline editors, we can simply add a `target` ("grid" or "composite") to identify where it was called. This will allow us to potentially disable some fields while doing inline editing but leave the same field enable when opening the Mass Update window from composite
- might as well also add the `compositeEditorOptions` in case we need to know if the Composite Modal is of type Mass Update, Edit, ...
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 212
Lines 12716 12716
Branches 4169 4169
=========================================
Hits 12716 12716
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onBeforeEditCellis called by the Composite Editor modal or by the inline editors, we can simply add atarget("grid" or "composite") to identify where it was called. This will allow us to potentially disable some fields while doing inline editing but leave the same field enable when opening the Mass Update window from compositecompositeEditorOptionsin case we need to know if the Composite Modal is of type Mass Update, Edit, ...