Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure DOM alterations during initialization are always cleaned up #1751

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ghiscoding
Copy link
Owner

  • this change was implemented in this SlickGrid PR and I'm not sure that it will make any differences in here since SlickGrid has its own (different) auto-resizer and part of the code doesn't exists in here (only a small portion of the code was copied over), so this change might or not help at all.

Copy link

stackblitz bot commented Nov 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (b2f4f52) to head (0a1db9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1751     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         187     187             
  Lines       31119   31121      +2     
  Branches     9780    9780             
========================================
+ Hits        31030   31032      +2     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit c65466f into master Nov 27, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/empty-cache branch November 27, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant