Reducing time complexity

[Vsinghal339-source]

Describe the bug

We found that the due to the below code, the time complexity is O(n square) which can be reduced to O(n)

Modified code:

 DataView.getAllSelectedFilteredItems = function () {
      /* istanbul ignore if */
      if (!Array.isArray(this.selectedRowIds)) {
        return [];
      }

      const selectedRowIdSet = new Set(this.selectedRowIds); // Add new set 
      const intersection = this.filteredItems.filter((a) => selectedRowIdSet.has(a[this.idProperty]));
      return (intersection || []);
    }

Reproduction

For large data set, the page hange for 1 minute

Which Framework are you using?

React

Environment Info

| Executable          | Version |
| ------------------- | ------- |
| (framework used)    | VERSION |
| Slickgrid-Universal | VERSION |
| TypeScript          | VERSION |
| Browser(s)          | VERSION |
| System OS           | VERSION |

Validations

• Follow our Code of Conduct
• Read the Wikis.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• The provided reproduction is a minimal reproducible example of the bug.

[Vsinghal339-source]

@ghiscoding Please do check this

[ghiscoding]

That's a good suggestion, and I would really like if you could contribute directly to the project and be added as a contributor to the project. Would you like to contribute? If you need help on how to contribute then let me know.

The code you are referring to can be found in the SlickDataView file, you could also contribute directly from GitHub since this seems like a small change

slickgrid-universal/packages/common/src/core/slickDataview.ts

Lines 1546 to 1554 in 633c5be

	getAllSelectedFilteredItems<T extends TData>(): T[] {
	/* v8 ignore next 3 */
	if (!Array.isArray(this.selectedRowIds)) {
	return [];
	}
	const intersection = this.filteredItems.filter((a) => this.selectedRowIds!.some((b) => a[this.idProperty as keyof TData] === b));
	return (intersection || []) as T[];
	}

Also doing a search across the project, I see another section where we could also do the same approach.

slickgrid-universal/packages/common/src/editors/selectEditor.ts

Lines 227 to 238 in 633c5be

	// collection of strings, just return the filtered string that are equals
	if (this.collection.every(x => typeof x === 'number' || typeof x === 'string')) {
	return this.collection.filter((c: SelectOption) => selectedValues?.some(val => `${val}` === c?.toString()));
	}
	// collection of label/value pair
	const separatorBetweenLabels = this.collectionOptions?.separatorBetweenTextLabels ?? '';
	const isIncludingPrefixSuffix = this.collectionOptions?.includePrefixSuffixToSelectedValues ?? false;
	return this.collection
	.filter(c => selectedValues.some(val => `${val}` === c?.[this.valueName]?.toString()))
	.map(c => {

[Vsinghal339-source]

@ghiscoding Yes please add me as a contributor. THanks

[ghiscoding]

@ghiscoding Yes please add me as a contributor. THanks

You need to contribute a Pull Request (PR) to be a contributor, so I will wait for your PR then 😉

[Vsinghal339-source]

@ghiscoding Please review the PR #1670