Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Select Filter/Editor enableRenderHtml was wrong #1096

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

ghiscoding
Copy link
Owner

- fixes an issue identified in Angular-Slickgrid as per this issue ghiscoding/Angular-Slickgrid#1240
- the problem was when I moved to the new multiple-select-vanilla lib, I used the wrong flag, we need to use `renderOptionLabelAsHtml` when we want text labels and `useSelectOptionLabelToHtml` when we want values to be rendered as HTML, so the issue was that the flags were inversed and that is why it was showing the values instead of the text labels
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1096 (38cda32) into master (d9f2b8d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1096   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        16838     16842    +4     
  Branches      6044      6044           
=========================================
+ Hits         16838     16842    +4     
Files Changed Coverage Δ
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit 1f09eef into master Sep 5, 2023
@ghiscoding ghiscoding deleted the bugfix/ms-select-render-html branch September 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant