Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape ()\* chars in LDAP DN string (as per ldap-filter 0.3.0 breaking change) #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delfuego
Copy link

No description provided.

@delfuego
Copy link
Author

@gheeres Just an FYI that this resolves a breaking change in ldap-filter (that node-activedirectory depends on as a child dependency). I noticed the breaking change in ldap-filter 0.3.0 when I did a full node module reinstall today on a project of mine; ldap-filter got updated from 0.2.3 to 0.3.3 and many of my users could no longer log into the project. It turned out to be only the users who belonged to an AD group that has a parentheses character in its name.

This pull request properly-escapes the four characters that were added as mandatory-escape characters in ldap-filter 0.3.0.

I tested this change for all versions of ldap-filter between 0.2.2 and 0.3.3 (current), so it should not break projects that still have package-lock'ed versions of ldap-filter prior to (or later than) 0.3.0.

@delfuego delfuego changed the title escape ()\* charss in LDAP DN string (as per ldap-filter 0.3.0 breaking change) escape ()\* chars in LDAP DN string (as per ldap-filter 0.3.0 breaking change) Jul 24, 2020
@ghost ghost mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant