-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Server completions return a lot of colons #3575
Comments
I am seeing this as well on GGUF models. Running M2 Max. |
Likely some KV cache mis-management - need to take a look. Let us know more info if you find a additional repro steps |
Can you guys give #3588 and see if it fixes the issue? |
That fixes it! I compiled the bin with
It's not the easiest to reproduce on a consistent basis; sometimes it takes running the above a few dozen times to reproduce the colons. Thanks so much for the quick response and fix! This project is great and you guys do a wonderful job maintaining and updating it! |
Ever since #3228, completion requests to the server example occasionally return a good deal of consecutive colons before a readable response, and sometimes it's almost exclusively colons, for example:
{"content": "::::::::::::::::::::::::: Hello, I'm an AI created by ChatBot. How can I assist you today?"}
{"content": "::::::::::::::::?"}
I've tested on a range of models (Mythomax 13B, Mythomax Kimiko 13B, Luna 7B, MlewdBoros 13B, Synthia 7B) and get the same results. I can reproduce it by sending this body to the server continually:
{"n_predict":256,"prompt":"Text transcript of a never-ending conversation between User and Assistant.\n\n#User: hi there\n#Assistant:", "stop":["\n#","\nUser:","\nuser:","\n["]}
It does not happen on every response (about 1 in 5-10 responses experience this) but enough to be distracting and make me wonder if I'm doing something wrong. I know the
repeat_penalty
andlogit_bias
fields should help here, but they both seem to have no effect on the problem from my testing and also were not previously explicitly needed before the aforementioned PR.I'm running on an M1 Max chip and writing this as of commit 9f6ede1.
Does anyone have any insights into how I could fix this or if this is perhaps a bug in the server example?
The text was updated successfully, but these errors were encountered: