FXC requires ASCII HLSL code

[teoxoy]

pSourceName, pEntrypoint should also be ASCII.

See #5812 (comment) for all the details.

This needs work in naga to remap all non-ASCII identifiers to ASCII.

[workingjubilee]

I guess we could basically punycode them? except _ instead of -, obviously.

[teoxoy]

That sounds like a good solution but we might not have to do this at all since we will probably drop support for FXC. @nical is working on adding the DXC dlls in Firefox.

[jimblandy]

It's just identifiers, right? It should be easy to make the namer take care of this, it already rejects some characters so it might be doing this already.

It would be smart to add an assertion to the HLSL backend that the output is in fact ASCII.

On my phone, but, we probably have a bug in that we don't adjust entry point names for the namer's changes?

[teoxoy]

On my phone, but, we probably have a bug in that we don't adjust entry point names for the namer's changes?

That's a good point, looking a the code, I don't think we do. Could you open a new issue for it?