-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wgpu-hal.gles] Error log for failed GLES heuristics #5266
Merged
cwfitzgerald
merged 4 commits into
gfx-rs:trunk
from
PolyMeilex:error-log-for-gles-failed-heuristics
Feb 19, 2024
Merged
[wgpu-hal.gles] Error log for failed GLES heuristics #5266
cwfitzgerald
merged 4 commits into
gfx-rs:trunk
from
PolyMeilex:error-log-for-gles-failed-heuristics
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolyMeilex
force-pushed
the
error-log-for-gles-failed-heuristics
branch
from
February 18, 2024 20:37
9010732
to
8a56cea
Compare
PolyMeilex
force-pushed
the
error-log-for-gles-failed-heuristics
branch
from
February 18, 2024 20:45
8a56cea
to
6a3d81c
Compare
nical
previously requested changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks useful, thanks! Just a couple of tweaks and this is good to go.
cwfitzgerald
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
cwfitzgerald
added
the
PR: needs back-porting
PR with a fix that needs to land on crates
label
Feb 29, 2024
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Feb 29, 2024
Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Feb 29, 2024
Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald
removed
the
PR: needs back-porting
PR with a fix that needs to land on crates
label
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLES backend guesses the texture type, and it often guesses wrong, let's save people some debugging time by informing them about this madness until there is a proper solution.
Info about those limitations in #1614 and #1574
Related iced bug that took way too long to debug iced-rs/iced#2259