Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove naga's span and validate features #4705

Closed
teoxoy opened this issue Nov 17, 2023 · 1 comment · Fixed by #4706
Closed

Remove naga's span and validate features #4705

teoxoy opened this issue Nov 17, 2023 · 1 comment · Fixed by #4706
Labels
kind: refactor Making existing function faster or nicer naga Shader Translator

Comments

@teoxoy
Copy link
Member

teoxoy commented Nov 17, 2023

It's unclear why the spans are gated behind the span feature. They are essential for diagnostics, take almost no space, and all users of naga that I could find enable it or have it enabled because they depend on wgpu-core transitively.

The validate feature might have more value than span as it gates quite a bit more code than span but still gets enabled by wgpu-core unconditionally.

The main driving factor behind removing them is maintenance burden (having to always consider the case where those are not enabled).

Related (original PRs):

@teoxoy teoxoy added the kind: refactor Making existing function faster or nicer label Nov 17, 2023
@cwfitzgerald
Copy link
Member

To add more context, I have personally been bitten by the lack of both these features silently causing issues without real connection to why the problem is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: refactor Making existing function faster or nicer naga Shader Translator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants