Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgl] Create a hidden window per instance #4603

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Oct 28, 2023

This creates a hidden window per instance instead of of sharing a global one. I was running into issues using multiple OpenGL contexts on a single window in vger-rs's test suite.

@Zoxc Zoxc requested a review from a team as a code owner October 28, 2023 06:06
@Zoxc Zoxc force-pushed the wgl-instance-windows branch from 315520a to a6687b3 Compare October 28, 2023 07:31
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursed, I love it

Approved after nit

wgpu-hal/src/gles/wgl.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit ff1ba0b into gfx-rs:trunk Oct 30, 2023
27 checks passed
@Zoxc Zoxc deleted the wgl-instance-windows branch October 30, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants