Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need to call VaryingContext::validate at all when #[cfg(not(feature = "validate"))]? #4490

Closed
jimblandy opened this issue Apr 12, 2023 · 0 comments · Fixed by #4706
Closed

Do we need to call VaryingContext::validate at all when #[cfg(not(feature = "validate"))]? #4490

jimblandy opened this issue Apr 12, 2023 · 0 comments · Fixed by #4706
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator

Comments

@jimblandy
Copy link
Member

If I understand correctly, when the "validate" feature is not enabled, we should only do enough work to produce a ModuleInfo the backends can use, and no more. But naga::valid::Validator::validate_entry_point calls VaryingContext::validate on the entry point's arguments and return value, and I don't see that that contributes anything to the final ModuleInfo.

Should those calls be protected by a #[cfg(not(feature = "validate"))] condition?
@jimblandy jimblandy added the area: validation Issues related to validation, diagnostics, and error handling label Apr 12, 2023
@jimblandy jimblandy changed the title Do we need to call VaryingContext::validate atall when #[cfg(not(feature = "validate"))]? Do we need to call VaryingContext::validate at all when #[cfg(not(feature = "validate"))]? Apr 12, 2023
@jimblandy jimblandy mentioned this issue Apr 12, 2023
Merged
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@teoxoy teoxoy mentioned this issue Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[naga] remove span and validate features teoxoy/wgpu
2 participants
@jimblandy @cwfitzgerald