Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate cost / benefit of "span" feature #4433

Closed
jimblandy opened this issue May 12, 2023 · 0 comments · Fixed by #4706
Closed

Evaluate cost / benefit of "span" feature #4433

jimblandy opened this issue May 12, 2023 · 0 comments · Fixed by #4706
Labels
area: naga front-end kind: refactor Making existing function faster or nicer naga Shader Translator

Comments

@jimblandy
Copy link
Member

The "span" feature is essential for producing usable diagnostics. As we improve Naga's diagnostics I suspect it's going to become harder to maintain "span" as an optional feature, as opposed to simply providing it by default.

We should measure the impact of the "span" feature on speed, memory consumption, and code size, and see what it would cost to simply enable it unconditionally.

@jimblandy jimblandy added kind: refactor Making existing function faster or nicer area: naga front-end labels May 12, 2023
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: naga front-end kind: refactor Making existing function faster or nicer naga Shader Translator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants