Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeviceDescriptor.default_queue #4014

Open
ErichDonGubler opened this issue Aug 8, 2023 · 0 comments
Open

Add DeviceDescriptor.default_queue #4014

ErichDonGubler opened this issue Aug 8, 2023 · 0 comments
Labels
area: api Issues related to API surface area: correctness We're behaving incorrectly area: validation Issues related to validation, diagnostics, and error handling

Comments

@ErichDonGubler
Copy link
Member

Description
A clear and concise description of what the bug is.

  • The WebGPU spec. specifies that GPUDeviceDescriptor (viz., our DeviceDescriptor type) should contain a field called defaultQueue of type GPUBufferDescriptor, with default value set to {}.
  • GPUBufferDescriptor inherits from GPUObjectDescriptorBase, which means that a label can be specified.

☝🏻 We don't implement this yet. It's a relatively recent addition to the spec., so that's not a surprise, but we need it to fully implement the WebGPU spec.

Repro steps
Ideally, a runnable example we can check out.

TODO

Expected vs observed behavior
Clearly describe what you get, and how it goes across your expectations.

TODO

Extra materials
Screenshots to help explain your problem.
Validation logs can be attached in case there are warnings and errors.
Zip-compressed API traces and GPU captures can also land here.

It looks like the easiest way to implement this is to add the new field as the spec. specifies to DeviceDescriptor, and then use the label here.

Platform
Information about your OS, version of wgpu, your tech stack, etc.

N/A

@ErichDonGubler ErichDonGubler added area: validation Issues related to validation, diagnostics, and error handling area: api Issues related to API surface area: correctness We're behaving incorrectly labels Aug 8, 2023
@ErichDonGubler ErichDonGubler added this to the WebGPU Specification V1 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Issues related to API surface area: correctness We're behaving incorrectly area: validation Issues related to validation, diagnostics, and error handling
Projects
Status: No status
Development

No branches or pull requests

1 participant