wgpu-core
should enforce proper nesting of push_debug_group
and pop_debug_group
#3911
Labels
area: validation
Issues related to validation, diagnostics, and error handling
Milestone
There is no code in
wgpu-core
orwgpu-hal
to prevent unmatchedpush
andpop
calls at thewgpu
orWebGPU
level turning into unmatchedBegin
andEnd
calls at the Vulkan API. But on Vulkan,VUID-vkCmdEndDebugUtilsLabelEXT-commandBuffer-01912
requires:After much discussion, the VulkanValidationLayers people seemed to decide that this was impossible to check in the validation layer, and the check was removed altogether. But the VUID is still in the spec, so Vulkan implementations have the right to assume the stack won't underflow.
wgpu-core
should require that the command buffers submitted to a queue produce properly nested push and pop pairs, to ensure that our usage respects the specification.Issue #3377 shows that even stricter limitations may be necessary to avoid bugs in certain versions of Mesa. But
wgpu-core
should always respect the Vulkan spec's general rules.The text was updated successfully, but these errors were encountered: