Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu-hal doesn't compile for Vulkan without Metal on Mac #3699

Closed
meyerzinn opened this issue Apr 18, 2023 · 2 comments
Closed

wgpu-hal doesn't compile for Vulkan without Metal on Mac #3699

meyerzinn opened this issue Apr 18, 2023 · 2 comments
Labels
api: vulkan Issues with Vulkan platform: macos Issues with integration with macos type: bug Something isn't working

Comments

@meyerzinn
Copy link

Description

cargo build --features vulkan
error[E0433]: failed to resolve: could not find `metal` in the crate root
   --> wgpu-hal/src/vulkan/instance.rs:454:20
    |
454 |             crate::metal::Surface::get_metal_layer(view as *mut objc::runtime::Object, None)
    |                    ^^^^^ could not find `metal` in the crate root

wgpu-hal/src/vulkan/instance.rs#L454 is the sad line.

Expected vs observed behavior

That almost certainly needs to be pulled into a wgpu-hal/auxil submodule, with all the dependencies set up right

-@cwfitzgerald

Platform

M1 MacBook Air (2020) running Ventura (13.3.1) with the latest Vulkan SDK (1.3.243).

@teoxoy teoxoy added type: bug Something isn't working api: vulkan Issues with Vulkan platform: macos Issues with integration with macos labels Apr 24, 2023
@jinleili
Copy link
Contributor

It seems that this issue cannot be reproduced on the latest trunk branch.

@Wumpf
Copy link
Member

Wumpf commented Jul 23, 2023

confirmed!
as of #3964 we're even running with molten-vk on ci now!
not entirely sure which pr fixed the feature compilation issue but seems to be a bit further back

@Wumpf Wumpf closed this as completed Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vulkan Issues with Vulkan platform: macos Issues with integration with macos type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants