Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Both fxhash and rustc-hash are in the dependency tree #3369

Closed
james7132 opened this issue Jan 10, 2023 · 0 comments · Fixed by #3502
Closed

Both fxhash and rustc-hash are in the dependency tree #3369

james7132 opened this issue Jan 10, 2023 · 0 comments · Fixed by #3502
Labels
area: infrastructure Testing, building, coordinating issues type: enhancement New feature or request

Comments

@james7132
Copy link
Contributor

naga uses rustc-hash and wgpu-hal uses fxhash. Both do the same thing, but both are being compiled separately. rustc-hash has hit 1.0, has been more recently updated, and is maintained by the rustlang devs themselves. It may be worth changing the fxhash dependency on wgpu-hal to rustc-hash.
@teoxoy teoxoy added type: enhancement New feature or request area: infrastructure Testing, building, coordinating issues labels Jan 11, 2023
@james7132 james7132 mentioned this issue Feb 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: infrastructure Testing, building, coordinating issues type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace fxhash with rustc-hash james7132/wgpu
2 participants
@james7132 @teoxoy