Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu::backend::web::Context::queue_validate_write_buffer is unimplemented #3085

Closed
jimblandy opened this issue Oct 8, 2022 · 1 comment · Fixed by #3098
Closed

wgpu::backend::web::Context::queue_validate_write_buffer is unimplemented #3085

jimblandy opened this issue Oct 8, 2022 · 1 comment · Fixed by #3098
Labels
api: webgpu Issues with direct interface with WebGPU help required We need community help to make this happen. type: enhancement New feature or request

Comments

@jimblandy
Copy link
Member

jimblandy commented Oct 8, 2022

The body of the implementation of wgpu::Context::queue_validate_write_buffer for web::Context is a "TODO" comment. Presumably the underlying web APIs will do the validation anyway, but it would make wgpu present errors more consistently if we did implement this.

(This is no surprise to anyone, but I generally feel that "TODO" comments should be avoided in favor of issues, since our tools for tracking the latter are much better.)

wgpu/wgpu/src/backend/web.rs

Lines 2286 to 2294 in 6451d31

fn queue_validate_write_buffer(
&self,
_queue: &Self::QueueId,
_buffer: &Self::BufferId,
_offset: wgt::BufferAddress,
_size: wgt::BufferSize,
) {
// TODO
}

cc: @teoxoy

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request help required We need community help to make this happen. api: webgpu Issues with direct interface with WebGPU labels Oct 8, 2022
@teoxoy
Copy link
Member

teoxoy commented Oct 8, 2022

I think this was blocked by web_sys not exposing buffer size and usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: webgpu Issues with direct interface with WebGPU help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants