Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk backend cannot correctly handle extended vk::format 's properties #2969

Closed
jinleili opened this issue Aug 17, 2022 · 1 comment
Closed

Comments

@jinleili
Copy link
Contributor

Description
vk backend fn query_format_properties cannot include the extended vk::format, cause validation error when using ASTC_XX_SFLOAT_BLOCK_EXT:

InvalidFormatUsages(COPY_DST | TEXTURE_BINDING, Astc { block: B8x8, channel: Hdr }, true)

query_format_properties assumes that the value of vk::format is in the [0, 184] range, but that is not true:
https://github.com/ash-rs/ash/blob/e5c4d11b03c29f66d10c14a0f10bd80999f9267e/ash/src/vk/feature_extensions.rs#L24-L60
https://github.com/ash-rs/ash/blob/e5c4d11b03c29f66d10c14a0f10bd80999f9267e/ash/src/vk/feature_extensions.rs#L340-L359

Platform
wgpu master, vulkan backend.

@jinleili
Copy link
Contributor Author

Closed by #2971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant