Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 11's WARP Passes the Water Example Image Comparison Test #2760

Closed
cwfitzgerald opened this issue Jun 10, 2022 · 2 comments
Closed

Windows 11's WARP Passes the Water Example Image Comparison Test #2760

cwfitzgerald opened this issue Jun 10, 2022 · 2 comments
Labels
api: dx12 Issues with DX12 or DXGI area: infrastructure Testing, building, coordinating issues help required We need community help to make this happen. type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Jun 10, 2022

Description

Follow up to #2746 which found that Windows 11's version of WARP passes the image comparison tests while Windows 10's don't. We currently have no way of representing this state in our testing framework.

We need some way of exposing something like the driver version, which we can hopefully use to guard the tests.

Repro steps

Run cargo nextest run water and see the test fail because the image comparison succeeded.

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request help required We need community help to make this happen. area: infrastructure Testing, building, coordinating issues api: dx12 Issues with DX12 or DXGI labels Jun 10, 2022
@PrototypeNM1
Copy link
Contributor

PrototypeNM1 commented Jul 11, 2022

DirextX doesn't seem to provide a way of getting the driver version directly, so you have to dig through the registry instead. GPUDetect implements the prior explanation plus verifying the LUID here.

I pulled these values from three PCs: one that came with Windows 11, one that was upgraded to Windows 11, and one on Windows 10.

OS Product Version Subversion Build Age
Windows 11 0xa 0x0000 0x55f0 0x0001 newest
Windows 11 (upgraded) 0xa 0x0000 0x55f0 0x0001 newest
Windows 11 (upgraded) 0xa 0x0000 0x4a61 0x0364 oldest
Windows 10 0xa 0x0000 0x4a61 0x0364 newest
Windows 10 0xa 0x0000 0x4a61 0x0054 oldest

The Subversion field being >=0x55f0 seems to be a reliable indicator of the Microsoft Basic Render Driver being the fixed Windows 11 driver, 0x4a61 being the original Windows 10 driver.

@cwfitzgerald
Copy link
Member Author

All good information - I think as this is a testing problem, we should just encourage people who hit this problem to get the new WARP nuget package, so they can just fix the problem.

I will look to get information on how to actually use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dx12 Issues with DX12 or DXGI area: infrastructure Testing, building, coordinating issues help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants