Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the msaa-line example in firefox has no multi-sample effect #2668

Closed
jinleili opened this issue May 17, 2022 · 1 comment
Closed

Comments

@jinleili
Copy link
Contributor

Description
msaa-line runs perfectly on macOS native, but running on ff via cargo run-wasm --example mass-line has no effect.
截屏2022-05-17 17 11 05
surface.get_preferred_format(&adapter).unwrap() equals Bgra8UnormSrgb and Bgra8Unorm on native and in the firefox, respectively. If modified configuration.format from surface.get_preferred_format(&adapter).unwrap() to Bgra8UnormSrgb, running in firefox also perfectly.

Spec says:

Note: Canvas configuration cannot use srgb formats like bgra8unorm-srgb. Instead, use the non-srgb equivalent (bgra8unorm), specify the srgb format in the viewFormats, and use createView() to create a view with an srgb format.

Does that mean that xx needs to be automatically reinterpreted as xx-srgb?

Platform
macOS, native + Firefox Nightly 102.0a1 (2022-05-16) (64-bit)

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Jun 2, 2022

That image is actually multi-sampled, but it's just multi-sampled in the wrong color space compared to the native ones, so the colors look different.

The problem with srgb is a keeping-up-with-the-spec issue and is covered by #2170

@cwfitzgerald cwfitzgerald closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants