Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GPU validation on DX12 and Vulkan #1709

Closed
1 of 2 tasks
kvark opened this issue Jul 22, 2021 · 1 comment · Fixed by #5046 or #5146
Closed
1 of 2 tasks

Enable GPU validation on DX12 and Vulkan #1709

kvark opened this issue Jul 22, 2021 · 1 comment · Fixed by #5046 or #5146
Assignees
@ErichDonGubler
Labels
area: infrastructure Testing, building, coordinating issues backend: dx12 Issues with DX12 or DXGI backend: vulkan Issues with Vulkan help required We need community help to make this happen.
Milestone
WebGPU Specificat...

Comments

@kvark
Copy link
Member

kvark commented Jul 22, 2021 •
edited by cwfitzgerald
Loading

Is your feature request related to a problem? Please describe.
Quite often, DX12 can fail without any clear validation error. It would help a ton if we could get more information about those.

Describe the solution you'd like
See https://docs.microsoft.com/en-us/windows/win32/direct3d12/using-d3d12-debug-layer-gpu-based-validation
We'll need a separate instance flag for this, since the perf penalty is greater.

Describe alternatives you've considered
Shoving this behind the existing VALIDATION flag

Additional context
Similar change will be needed in Vulkan. Distantly related to #1708

Checklist
@kvark kvark added area: infrastructure Testing, building, coordinating issues help required We need community help to make this happen. labels Jul 22, 2021
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 5, 2022
@ErichDonGubler ErichDonGubler self-assigned this Jan 8, 2024
@teoxoy teoxoy mentioned this issue Jan 11, 2024
Closed
@teoxoy teoxoy added backend: dx12 Issues with DX12 or DXGI backend: vulkan Issues with Vulkan labels Jan 11, 2024
@ErichDonGubler ErichDonGubler mentioned this issue Jan 11, 2024
Merged
6 tasks
@ErichDonGubler ErichDonGubler mentioned this issue Jan 26, 2024
Merged
4 tasks
@ErichDonGubler
Copy link
Member

I've edited the OP to contain a checklist of PRs I've filed to resolve this issue.

@github-project-automation github-project-automation bot moved this from Todo to Done in WebGPU for Firefox Jan 31, 2024
@cwfitzgerald cwfitzgerald reopened this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErichDonGubler ErichDonGubler

Labels
area: infrastructure Testing, building, coordinating issues backend: dx12 Issues with DX12 or DXGI backend: vulkan Issues with Vulkan help required We need community help to make this happen.
Projects
WebGPU for Firefox
Status: Done
Milestone
WebGPU Specification V1
4 participants
@kvark @ErichDonGubler @cwfitzgerald @teoxoy