Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Validation for Swapchains of Width or Height 0 #1026

Closed
cwfitzgerald opened this issue Nov 15, 2020 · 0 comments · Fixed by #1100
Closed

Add Validation for Swapchains of Width or Height 0 #1026

cwfitzgerald opened this issue Nov 15, 2020 · 0 comments · Fixed by #1100
Assignees
@cwfitzgerald
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working

Comments

@cwfitzgerald
Copy link
Member

Description

Creating a swapchain with height or width of 0 is UB under vulkan.

Extra materials

See also iced-rs/iced#603.

Platform

Intel/Windows is the only one who seems to care, but UB is UB.
@cwfitzgerald cwfitzgerald added type: bug Something isn't working area: validation Issues related to validation, diagnostics, and error handling labels Nov 15, 2020
@cwfitzgerald cwfitzgerald self-assigned this Nov 15, 2020
This was referenced Dec 1, 2020
Closed
Closed
Closed
Closed
@cwfitzgerald cwfitzgerald mentioned this issue Dec 21, 2020
Merged
@bors bors bot closed this as completed in 7e3965b Dec 22, 2020
@bors bors bot closed this as completed in #1100 Dec 22, 2020
@branpk branpk mentioned this issue Jun 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwfitzgerald cwfitzgerald

Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate swapchain extent as non-zero cwfitzgerald/wgpu
1 participant
@cwfitzgerald