From 9417623a6465c2964b67f39840d03ed489e91d0e Mon Sep 17 00:00:00 2001 From: Jim Blandy Date: Mon, 28 Aug 2023 18:09:10 -0700 Subject: [PATCH] Skip `test_multithreaded_compute` on MoltenVK. Skip `tests::test_multithreaded_compute` in `examples/hello-compute/src/tests.rs` on MoltenVK for timeouts. --- CHANGELOG.md | 2 ++ examples/hello-compute/src/tests.rs | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e168ebe8567..34647fbec14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -106,6 +106,8 @@ By @Valaphee in [#3402](https://github.com/gfx-rs/wgpu/pull/3402) - Ensure that MTLCommandEncoder calls endEncoding before it is deallocated. By @bradwerth in [#4023](https://github.com/gfx-rs/wgpu/pull/4023) +- Skip `test_multithreaded_compute` on MoltenVK. By @jimblandy in [#4096](https://github.com/gfx-rs/wgpu/pull/4096). + ### Documentation - Add an overview of `RenderPass` and how render state works. By @kpreid in [#4055](https://github.com/gfx-rs/wgpu/pull/4055) diff --git a/examples/hello-compute/src/tests.rs b/examples/hello-compute/src/tests.rs index 108cfe37158..c8df78627b4 100644 --- a/examples/hello-compute/src/tests.rs +++ b/examples/hello-compute/src/tests.rs @@ -82,7 +82,13 @@ fn test_multithreaded_compute() { // https://github.com/gfx-rs/wgpu/issues/3944 .backend_adapter_failure(wgpu::Backends::VULKAN, "swiftshader", true) // https://github.com/gfx-rs/wgpu/issues/3250 - .backend_adapter_failure(wgpu::Backends::GL, "llvmpipe", true), + .backend_adapter_failure(wgpu::Backends::GL, "llvmpipe", true) + .specific_failure(wgpu_test::FailureCase { + backends: Some(wgpu::Backends::VULKAN), + driver: Some("MoltenVK"), + skip: true, + ..wgpu_test::FailureCase::default() + }), |ctx| { use std::{sync::mpsc, thread, time::Duration};