Update to glutin 0.8, Winit 0.6 #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csherratt
force-pushed
the
master
branch
6 times, most recently
from
228b499 to
e7d9af3
Compare
|
Looks great! One small thing - gfx_app version also needs a bump. |
|
I wonder, where did travis go?.. |
|
@homu r+ |
|
📌 Commit 55d1347 has been approved by |
homu
added a commit
that referenced
this pull request
May 3, 2017
Update to glutin 0.8, Winit 0.6 This will require gfx_window_glutin to be published. I'm on linux and didn't get a chance to test the trianglell example.
|
💔 Test failed - status |
|
@homu r+ |
|
📌 Commit 0705a00 has been approved by |
homu
added a commit
that referenced
this pull request
May 3, 2017
Update to glutin 0.8, Winit 0.6 This will require gfx_window_glutin to be published. I'm on linux and didn't get a chance to test the trianglell example.
|
💔 Test failed - status |
|
Almost there! OSX just needs a fixup. |
|
@homu r+ |
|
📌 Commit 23ae748 has been approved by |
homu
added a commit
that referenced
this pull request
May 4, 2017
Update to glutin 0.8, Winit 0.6 This will require gfx_window_glutin to be published. I'm on linux and didn't get a chance to test the trianglell example.
|
☀️ Test successful - status |
|
Woohoo! |
Closed
|
May I ask for it to be published? |
|
@ishitatsuyuki I can publish |
|
I only need the glutin one. Thanks! |
|
@ishitatsuyuki ok, will do. Please use an override to a locally-checked-out crate in the meantime |
|
@ishitatsuyuki version 0.16.0 is published now from rev 162221c |
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
1251: Don't panic on pipeline creation errors r=kvark a=kvark **Connections** Related to Gecko crashes. **Description** We shouldn't ever panic in `wgpu`. The panic can only occur if there is internal inconsistency. For any invalid workloads, submitted by the user, we should produce errors instead. **Testing** Not tested Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require gfx_window_glutin to be published.
I'm on linux and didn't get a chance to test the trianglell example.