Issue 2359 get section by lang #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SumDonkuS
changed the title
|
Thinking about it a bit more, we don't have it for |
Keats
reviewed
Jan 18, 2024
…k for language available in config.
|
Good call on adding it to |
Keats
reviewed
Jan 22, 2024
| } | ||
| } | ||
|
|
||
| fn calculate_path<'a>( |
There was a problem hiding this comment.
i'm not sure calculate_path is the right name. get_path_with_lang? Not sure
| @@ -154,6 +160,12 @@ If you only need the metadata of the section, you can pass `metadata_only=true` | |||
| {% set section = get_section(path="blog/_index.md", metadata_only=true) %} | |||
| ``` | |||
|
|
|||
| If selecting a specific language for the section, you can pass `lang` with the language code to the function: | |||
There was a problem hiding this comment.
I would mention for pages and here that it's equivalent to {% set section = get_section(path="blog/_index.fr.md") %}
…. Modify documentation for get_section and get_page to include equivalent calls without using lang argument to demostrate how lang argument effects pathing.
|
Great. Changed the function name to be more specific, like you suggested. Also, added to the docs equivalencies based on if the language passed is the default language or not. |
Keats
approved these changes
Feb 4, 2024
|
Thanks! |
veluca93
pushed a commit
to veluca93/zola
that referenced
this pull request
May 14, 2024
* adding optional `lang` arugment to `get_section` global function * Add handling of default language passed in `lang` argument of `get_section` * Remove clones for path. Change "?" to an explicit check for error * lint changes * Clean up error handling for add_lang_to_path call * fix format * Add optional parameter "lang" to get_page template function. Add check for language available in config. * Modify helper function name from calculate_path to get_path_with_lang. Modify documentation for get_section and get_page to include equivalent calls without using lang argument to demostrate how lang argument effects pathing.
Keats
pushed a commit
that referenced
this pull request
Jun 20, 2024
* adding optional `lang` arugment to `get_section` global function * Add handling of default language passed in `lang` argument of `get_section` * Remove clones for path. Change "?" to an explicit check for error * lint changes * Clean up error handling for add_lang_to_path call * fix format * Add optional parameter "lang" to get_page template function. Add check for language available in config. * Modify helper function name from calculate_path to get_path_with_lang. Modify documentation for get_section and get_page to include equivalent calls without using lang argument to demostrate how lang argument effects pathing.
berdandy
pushed a commit
to berdandy/azola
that referenced
this pull request
Sep 17, 2024
* adding optional `lang` arugment to `get_section` global function * Add handling of default language passed in `lang` argument of `get_section` * Remove clones for path. Change "?" to an explicit check for error * lint changes * Clean up error handling for add_lang_to_path call * fix format * Add optional parameter "lang" to get_page template function. Add check for language available in config. * Modify helper function name from calculate_path to get_path_with_lang. Modify documentation for get_section and get_page to include equivalent calls without using lang argument to demostrate how lang argument effects pathing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding optional
langargument forget_sectionglobal function. Language code will be added to the filename if it is not the default language. Related issue here.Sanity check:
Code changes
nextbranch?If the change is a new feature or adding to/changing an existing one: