Broken shortcodes on 0.19

[1player]

I had a shortcode called email which contained my email address for reasons, and used it as such

<a name="contact-me" href="mailto:{{ email() }}">{{ email() }}</a>

This used to work but I have since upgraded to 0.19.1 and it simply outputs @@ZOLA_SC_PLACEHOLDER@@

I had to move the entire tag into the shortcode for it to work again, but this smells like a bug and a regression to me.

[Keats]

You had that line the markdown right? If so might be a regression in shortcodes in HTML due to the pulldown-cmark update.

[jcla1]

I am also having this issue. On a markdown page I have multiple a-hrefs and use a shortcode to link to static resources. They now, on most pages, show up as @@ZOLA_SC_PLACEHOLDER@@. Weird is though that it's not on all pages - more recently updated ones (but with the same a-href and shortcode) don't seem to suffer this issue.

[Keats]

Can you share an example md file that has the issue?

[jcla1]

Here are some example files - the first one, with zola's current version, produces links where the final bit of the URL is the placeholder (not the whole URL). The second markdown file produces the correct links.

numerik1_ss2021.md
analysis2_ss2024.md

I've checked this again, by deleting the public directory and then doing a clean build with zola v0.19.1.

[jcla1]

For anyone using zola via homebrew: I found a nice guide that explains how to get an older version of a formula. I'm now back on v0.18.0 and that doesn't have the issue with the placeholder.

[Keats]

Ok I can reproduce it with your files. For some reasons it's the

2021-07-26: **Das Ferientutorium zur Numerik I wird vom 20. September bis zum
24. September täglich von 10 bis 16 Uhr via [WebEx][15] stattfinden. Es wird
veranstaltet von Melinda Hagedorn, die freundlicherweise bereits <a href="{{ get_url(path = "static/numerik1_ss2021/zusatzuebungen.pdf") }}">Aufgaben
zum selbststudium</a> bereit gestellt hat, die im Laufe des Tutoriums dann
besprochen werden können. Eine Anmeldung ist nicht erforderlich.**

paragraph that causes issues. If i remove the HTML tag in there it does render the rest fine 🤔

[LunarEclipse363]

You had that line the markdown right? If so might be a regression in shortcodes in HTML due to the pulldown-cmark update.

IIRC I tracked this down to 13682e1 specifically at some point so yeah.

[Keats]

If anyone is interested, since we have a repro above, we should be able to write tests and fix it somewhat easily. It could be a good first issue!

[amtanq]

Working on this

[amtanq]

Raised a fix: #2601
Edit: Better fix by @clarfonthey -> #2606

[MaxIhlenfeldt]

I'm still seeing a variant of this issue with v0.19.2.

I want to link to a non-content page from Markdown on a site where the base URL has the form $DOMAIN/$DIRECTORY, e.g. example.com/my-site. I can't use the @/ link syntax because the link target is not in the content directory, I can't use a root-relative link because that strips the my-site part of the base URL, and I don't want to use a relative link to prevent breaking stuff in case I change something in the future.

Thus, I created templates/shortcodes/get_url.html so I could use get_url inside Markdown:

{{ get_url(path=path) }}

And use it like this in content/test.md:

[link]({{ get_url(path="/tags/example") }})

However, the generated HTML is:

<p><a href="https://example.com/my-site/test/@@ZOLA_SC_PLACEHOLDER@@">link</a></p>

Instead of the expected:

<p><a href="https://example.com/my-site/tags/example">link</a></p>

[MaxIhlenfeldt]

Hm, it seems that the above was already not working in v0.17 and v0.18 (possibly even earlier, I get unrelated build errors with v0.16 or earlier).

[Keats]

Looks like we are not looking in places like links for shortcodes