Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to disable version check via environment variable #1684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicklasfrahm
Copy link

Closes #1665.

@felixfontein felixfontein changed the title fix(version): allow users to disable version check via environment variable Allow users to disable version check via environment variable Nov 25, 2024
@felixfontein
Copy link
Contributor

I changed the title since this isn't a fix, but a feature.

@felixfontein felixfontein added this to the 3.10.0 milestone Nov 25, 2024
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

version/version.go Outdated Show resolved Hide resolved
@nicklasfrahm nicklasfrahm force-pushed the feature/remote-version branch 3 times, most recently from 85235ed to 38fdd3f Compare November 25, 2024 21:19
@nicklasfrahm
Copy link
Author

@felixfontein I have adjusted the code according to your suggestion and updated the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any way to disable probing GitHub?
2 participants