ref(replay): make configure replay card mobile-specific #82120
Conversation
github-actions
bot
added
the
Scope: Frontend
| @@ -95,7 +96,7 @@ export default function Page({ | |||
| ) : ( | |||
| <Fragment> | |||
| {isVideoReplay ? <FeedbackWidgetButton /> : <FeedbackButton />} | |||
| {isVideoReplay ? null : <ConfigureReplayCard />} | |||
| {isVideoReplay ? <ConfigureMobileReplayCard /> : <ConfigureReplayCard />} | |||
There was a problem hiding this comment.
Looks like we have the replayRecord already is it's not still loading. Maybe we can pass in the platform and deep link to the specific docs for the project that the replay is inside; whether that's mobile or web specific.
Maybe if the replayRecord is still loading then picks. Default value, or change links to somewhere else.. I'm thinking aloud here tho
There was a problem hiding this comment.
i thought about that but it's hard because the apple docs are structured differently in the URL than the react native or android. apple has an extra .../apple/guides/ios/session-replay/ while android is .../android/session-replay/ which means we have to case on the platform. it was already sort of a pain for the onboarding, and if we want to do it again for even more platforms then it could get complicated
plus if we cased on the platform for mobile then we'd have to do it for web, and there are a lot more web docs, esp the javascript sub-platforms. ex .../javascript/guides/angular/session-replay/
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82120 +/- ##
==========================================
- Coverage 80.36% 77.22% -3.15%
==========================================
Files 7277 7277
Lines 321491 321489 -2
Branches 20966 20966
==========================================
- Hits 258380 248256 -10124
- Misses 62703 72825 +10122
Partials 408 408 |
closes #72231
the web replay configure links go to the
javascriptdocs links, so they're not platform-specific. we are assuming the user will change their platform in the docs as needed. i chose to use theandroiddocs links for the mobile card but can switch to any other platform if it makes more sense.